Fix compatibility with doctrine/orm ^2.6 (#181) #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MichelFalke
commented
Jan 11, 2019
MichelFalke
commented
- Renamed functions because of an inheritance issue with doctrine ^2.6
* Renamed functions because of an inheritance issue with doctrine ^2.6
MichelFalke
force-pushed
the
feature/fix-compatibility-issues-with-doctrine
branch
from
98a5089
to
4c7b369
Compare
UPGRADE.md
Outdated
| @@ -1,5 +1,11 @@ | |||
| # Upgrade | |||
|
|
|||
| ## 1.0.0-RC6 | |||
| For the compatibility with `doctrine/orm ^2.6` the function names of the FromRepository are edited to avoid inheritance issues. | |||
There was a problem hiding this comment.
add an empty line before and after this line. and there is a small typo in Form... (From...) and I would write are renamed
|
@MichelFalke Thank you for fixing this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.