Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list heading does not fallback to default locale #359

Conversation

dev-newvisibility
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

This PR fixes the heading of form listings that show the field keys instead of their labels. This happens when the form is not localised in the admin's language.

Why?

We have a form that is localized in italian only. But our admin account use english as preferred language:

The first image shows the listing without the fix:
nok

The second one with the fix:
ok

@alexander-schranz alexander-schranz merged commit 028a831 into sulu:2.5 Apr 24, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants