Add caching to navigation and snippet controller #112
Conversation
Prokyonn
force-pushed
the
enhancement/caching
branch
from
659e839
to
8d26645
Compare
Controller/NavigationController.php
Outdated
| // 7 days | ||
| public const NAVIGATION_CACHE_LIFE_TIME = '604800'; |
There was a problem hiding this comment.
Should be configureable.
Controller/SnippetAreaController.php
Outdated
| // 7 days | ||
| public const SNIPPET_AREA_CACHE_LIFE_TIME = '604800'; |
There was a problem hiding this comment.
Should be configureable.
| Events::PUBLISH => ['invalidateNavigationContextBeforePublishing', 8192], | ||
| Events::UNPUBLISH => ['invalidateNavigationContextBeforeUnpublishing', 8192], | ||
| Events::REMOVE => ['invalidateNavigationContextBeforeRemoving', 8192], | ||
| Events::REMOVE_LOCALE => ['invalidateNavigationContextBeforeRemovingLocale', 8192], |
There was a problem hiding this comment.
This listeners should just collect the data.
And a Flush method with allow priority should then call the CacheManager.
Do not forget to implement kernel.reset event to empty the array and empty the array.
Co-authored-by: Alexander Schranz <alexander@sulu.io>
@alexander-schranz do we really need one? At the moment it is working, as soon as the snippet is modified, the tag is invalidated through the default InvalidationSubscriber from the HttpCacheBundle |
|
@Prokyonn but if a default snippet is changed to another default snippet the cache need to be invalided also. Else you will get a long time the old default snippet. |
Prokyonn
force-pushed
the
enhancement/caching
branch
from
3cb7665
to
f36dcb0
Compare
| * | ||
| * @internal | ||
| */ | ||
| class NavigationInvalidationSubscriber implements EventSubscriberInterface |
There was a problem hiding this comment.
would add the ResetInterface here.
Add caching and tag invalidation support for
NavigationControllerandSnippetAreaController