Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 6 #115

Merged
merged 2 commits into from Jul 14, 2022
Merged

Allow Symfony 6 #115

merged 2 commits into from Jul 14, 2022

Conversation

chalasr
Copy link
Contributor

@chalasr chalasr commented Jul 12, 2022

No description provided.

@alexander-schranz alexander-schranz added the DX Only affecting the end developer label Jul 12, 2022
@alexander-schranz
Copy link
Member

Replace of static::$container -> static::getContainer() should fix the failing tests for Symfony 6 :)

@alexander-schranz
Copy link
Member

Seems routing file still uses the old controller:action instead of controller::action format. Not sure if controller::action is compatible to symfony 4.4. Else I would discuss with our partners if symfony 4.4 support is still required or if we could drop it 🤔

_controller: sulu_headless.controller.navigation:getAction

@chalasr
Copy link
Contributor Author

chalasr commented Jul 14, 2022

The recommended notation should be compatible with 4.4 :) PR updated

@alexander-schranz
Copy link
Member

alexander-schranz commented Jul 14, 2022

Next one 😄 seems to be

$structureResolver = $this->get('sulu_headless.structure_resolver');
. I think this $this->get( need to be now $this->container->get( 🤔

@chalasr
Copy link
Contributor Author

chalasr commented Jul 14, 2022

Fixed along with a remaining self::$container access in tests! 🤞

@alexander-schranz alexander-schranz merged commit f85afa1 into sulu:0.x Jul 14, 2022
@alexander-schranz
Copy link
Member

Nice @chalasr thank you!

@chalasr chalasr deleted the sf-6 branch July 14, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Only affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants