Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference store integration for StructureResolver #78

Merged
merged 9 commits into from Mar 24, 2021
Merged

Add reference store integration for StructureResolver #78

merged 9 commits into from Mar 24, 2021

Conversation

alexander-schranz
Copy link
Member

No description provided.

@alexander-schranz alexander-schranz added the Feature New functionality not yet included in the Bundle label Mar 17, 2021
@alexander-schranz alexander-schranz force-pushed the feature/reference-store branch 2 times, most recently from 8028edd to 6af95d9 Compare March 17, 2021 11:10
@alexander-schranz alexander-schranz marked this pull request as draft March 17, 2021 13:03
@alexander-schranz
Copy link
Member Author

When implementing #79 I thought it would be better to move the reference store to the serializer services. There sadly does not exist a PageSerializer, there the general StructureResolver is used, which I totally forget in all cases need a referenceStore so the page itself can be invalidated by the tag. Sadly the StructureResolver would need to know multiple reference store. How do we handle this? I could go on the StructureType or what is called but would the reference store for the pages was not updated and still use the old content name so I would to implement a mapping:

  • article -> article
  • snippet -> snippet
  • content -> page

@alexander-schranz alexander-schranz marked this pull request as ready for review March 18, 2021 12:28
niklasnatter
niklasnatter reviewed Mar 23, 2021
View reviewed changes
Content/StructureResolver.php Outdated Show resolved Hide resolved
Content/StructureResolver.php Outdated Show resolved Hide resolved
Tests/Unit/Content/StructureResolverTest.php Outdated Show resolved Hide resolved
@niklasnatter niklasnatter changed the title Add reference store integration for page resolver and page data provider Add reference store integration for StructureResolver Mar 24, 2021
@niklasnatter niklasnatter merged commit cf92090 into sulu:0.x Mar 24, 2021
@alexander-schranz alexander-schranz deleted the feature/reference-store branch March 24, 2021 10:26
@alexander-schranz alexander-schranz mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wachterjohannes wachterjohannes wachterjohannes approved these changes

@niklasnatter niklasnatter niklasnatter approved these changes

Assignees

@alexander-schranz alexander-schranz

@niklasnatter niklasnatter

Labels
Feature New functionality not yet included in the Bundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-schranz @wachterjohannes @niklasnatter