This repository has been archived by the owner on Sep 23, 2020. It is now read-only.
[FEATURE] Added addon prices to products api #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-ele
force-pushed
the
feature/product-addon-prices
branch
2 times, most recently
from
6cf6af2
to
27712e6
Compare
turbo-ele
force-pushed
the
feature/product-addon-prices
branch
from
27712e6
to
1bc25c2
Compare
wachterjohannes
suggested changes
Nov 4, 2016
| * @param string $locale | ||
| * @param PriceFormatter $priceFormatter | ||
| */ | ||
| public function __construct( |
There was a problem hiding this comment.
should fit into a single line
| ); | ||
| $apiAddon->setAddonPrices(iterator_to_array($addon->getAddonPrices())); |
There was a problem hiding this comment.
why not passing to to the function call? maybe with default value?
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function createAddonProductApiEntity(ProductInterface $product, $locale) |
There was a problem hiding this comment.
add prices with default value[]. and to the constructor.
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function setAddonPrices(array $addonPrices) |
There was a problem hiding this comment.
add this to the constructor and remove this function.
turbo-ele
force-pushed
the
feature/product-addon-prices
branch
from
b269359
to
37fc1fc
Compare
wachterjohannes
approved these changes
Nov 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
In this PR, addon-prices are introduced to products api. Before this PR you were able to define prices for Product-Addon relations but could not derive them through an API call.
Example Usage
yourdomain.com/admin/api/products/idBC Breaks/Deprecations
createAddonProductApiEntityProductFactoryto be passed to the constructor.