Match source and sourcehost case insensitively #63
Conversation
| @@ -49,7 +49,7 @@ public function getRouteCollectionForRequest(Request $request) | |||
| } | |||
|
|
|||
| $route = new Route( | |||
| $redirectRoute->getSource(), | |||
| $pathInfo, | |||
There was a problem hiding this comment.
@nnatter why this change?
There was a problem hiding this comment.
Is this the route name? Should we maybe more go with: 'sulu_redirect.redirect_' . $redirectRoute->getId() or something 🤔
There was a problem hiding this comment.
no it is the path of the route. this is used for generating the regex of the route here:
https://github.com/symfony/symfony/blob/252f85c2c249da7d8f2a490b57cc71199d51fcc9/src/Symfony/Component/Routing/RouteCompiler.php#L75-L92
it looks like the regex is evaluated case sensitive. if we pass /test123 here but the request contains TEST123, symfony will not match the request to the route
There was a problem hiding this comment.
Okay this make sense not sure if we need to use here $pathInfo or $request->getPathInfo 🤔
niklasnatter
force-pushed
the
enhancement/case-insensitive-url
branch
from
1acf7c9
to
04d6bdc
Compare
niklasnatter
force-pushed
the
enhancement/case-insensitive-url
branch
from
573762b
to
3994a2c
Compare
niklasnatter
force-pushed
the
enhancement/case-insensitive-url
branch
from
3994a2c
to
2adfae2
Compare
What's in this PR?
This PR adjusts the code to match the
sourceandsourceHostof a redirect in a case-insensitive manner.Assuming a redirect with
source: "redirect-url", sourceHost: "www.test.com":Behaviour before: matches only
www.test.com/redirect-urlBehaviour after: matches
www.test.com/redirect-url,www.test.com/redirect-URL,www.test.com/REDIRECT-url, ...Why?
Because MySQL is case insensitive by default. This means it is not possible to create two redirects that use the same characters (eg. one redirect for
redirect-urland one redirect forredirect-URL).Because of this, without this change, it is not possible to redirect both urls (
www.test.com/redirect-urlandwww.test.com/redirect-URL) at all.