Add support for symfony 5 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/symfony-5-recipe-update
branch
from
eb01f65
to
02b7c02
Compare
| @@ -1,22 +0,0 @@ | |||
| <?php | |||
There was a problem hiding this comment.
The bootstrap file was removed and replaced in symfony 5.1 by a new DotEnv->bootEnv method.
alexander-schranz
force-pushed
the
feature/symfony-5-recipe-update
branch
4 times, most recently
from
64ed106
to
40be239
Compare
| "dantleech/phpcr-migrations-bundle": "^1.0", | ||
| "doctrine/doctrine-bundle": "^1.10 || ^2.0", | ||
| "dantleech/phpcr-migrations-bundle": "^1.2", | ||
| "doctrine/doctrine-bundle": "^2.0", |
There was a problem hiding this comment.
As discussed with @chirimoya as the recipes only match the new version we will require the newest symfony package versions in the skeleton for new projects.
There was a problem hiding this comment.
This is not really a BC break, because existing projects don't necessarily have to update, right?
There was a problem hiding this comment.
Yes this is not a BC Break, the skeleton should from my side always represent how a new project should look like.
alexander-schranz
force-pushed
the
feature/symfony-5-recipe-update
branch
3 times, most recently
from
823c764
to
ed253ba
Compare
alexander-schranz
force-pushed
the
feature/symfony-5-recipe-update
branch
from
ed253ba
to
a2ca1a2
Compare
|
Currently the CI is failing because of: We could currently work around by inlining the event name and not using the parameter: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Update recipes to newest versions, so new sulu installations get configuration from symfony 5.
Why?
Add support for symfony 5.
To Do