Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sulu SecuritySubscriber should not throw exception when User is not an instance of UserInterface #3389

Closed
cdesign opened this issue Jun 6, 2017 · 1 comment

Comments

@cdesign
Copy link
Contributor

cdesign commented Jun 6, 2017

Q A
Bug? yes
New Feature? no
Sulu Version 1.5.4

Actual Behavior

The Sulu SecuritySubscriber throws an error when the user is not an instance of Sulu\Component\Security\Authentication\UserInterface. As far as I can tell, this prevents one from using a custom user provider on a secured route (where the site has tokenStorage).

I our case, this prevents us from using the Symfony LDAP component to authenticate users to the web front end.

Expected Behavior

SecuritySubscriber should return null instead of throw an exception when the user does not implement the Sulu UserInterface.

https://github.com/sulu/sulu/blob/develop/src/Sulu/Bundle/DocumentManagerBundle/Document/Subscriber/SecuritySubscriber.php#L70

@danrot
Copy link
Contributor

danrot commented Jun 14, 2017

fixed in #3404

@danrot danrot closed this as completed Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants