Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent localization codes #71

Closed
danrot opened this issue Mar 15, 2014 · 4 comments
Closed

Use consistent localization codes #71

danrot opened this issue Mar 15, 2014 · 4 comments

Comments

@danrot
Copy link
Contributor

danrot commented Mar 15, 2014

The use of localization codes is not consistent (sometimes de_at, sometimes de-at). We should stick with one representation in the API and transfer them at the appropriate places.

The following code lines show what I mean:
https://github.com/sulu-cmf/sulu/blob/e4404de197fc8a77a86f388b379548025a3116fd/tests/Sulu/Component/Content/Mapper/ContentMapperTest.php#L1474
https://github.com/sulu-cmf/sulu/blob/e4404de197fc8a77a86f388b379548025a3116fd/tests/Sulu/Component/Content/Mapper/ContentMapperTest.php#L1481
@danrot
Copy link
Contributor Author

danrot commented Mar 22, 2014

@wachterjohannes Is this inconsistency removed? If yes, please close this issue.

@wachterjohannes
Copy link
Member

@danrot i will check this next week and close it then(=

@danrot
Copy link
Contributor Author

danrot commented May 9, 2014

@wachterjohannes so it was not fixed? ;-)

@wachterjohannes
Copy link
Member

it will be generated only with '_' here https://github.com/sulu-cmf/sulu/blob/develop/src/Sulu/Component/Webspace/Localization.php#L145

wachterjohannes added a commit that referenced this issue Aug 14, 2014
@wachterjohannes
Merge pull request #71 from sulu-cmf/feature/css-adaptions
7efa224 
feature/css-adpations
danrot added a commit that referenced this issue Aug 14, 2014
@danrot
Merge pull request #71 from sulu-cmf/feature/edit-address
1f6a9af 
Feature/edit address
wachterjohannes added a commit that referenced this issue Oct 31, 2014
@wachterjohannes
Merge pull request #71 from sulu-cmf/feature/css-adaptions
cd3874f 
feature/css-adpations
danrot added a commit that referenced this issue Oct 31, 2014
@danrot
Merge pull request #71 from sulu-cmf/feature/edit-address
503a135 
Feature/edit address
alexander-schranz pushed a commit to alexander-schranz/sulu that referenced this issue Feb 22, 2024
@danrot @chirimoya
Extract webpack configuration to other repository (sulu#71)
c18c4fd 
* move postcss configuration to sulu/sulu

* remove babel configuration from webpack config

* extracted webpack

* build new version

* add travis for testing build process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danrot @wachterjohannes