-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing PostgreSQL support #1722
Conversation
1525453
to
fe4f0e1
Compare
Update: Of the originally failing bundles, we're about half way there. #1720, #1725, #1726 fixes Categories, Contacts and Tags respectively. (@danrot: please review at your leisure.) I have to pause until next week now but I will continue with Here's one run:
And here's another one straight after:
Same tests. Different failures. :-) Again it'll just be a case of providing Postgres with the correct ordering. (There is an Having got this far without incident I'm optimistic that |
fe4f0e1
to
c41225a
Compare
Postgres doesn't share the default ordering by ID. We have to specify the ordering. I'm not 100% certain as yet what the default ordering is but it's not stable with respect to `id` and, as such, we were getting different failures on different test runs. Fun!
Doctrine wraps DB specific error codes.
c41225a
to
b4a1dd8
Compare
95a3061
to
bda9d1b
Compare
@carltongibson The progress already looks quite good, there aren't too many failing tests left. However, it would be good if we don't wait too long on finishing this, I've already seen a new feature failing some tests again 😕 |
@danrot Yeah — I didn't think I was far off. IIRC there were remaining ordering issues — with intermittent failures and that was about it. (I thought ordering the relations may be all that's needed there — but didn't get to check that.) Will say more in Feb! Ping me on anything relevant so I can keep up. |
Replaced by #2703 |
This branch is activating the build for PostgreSQL, which is currently failing. @carltongibson will create some Pull Requests targeted at this branch to fix this.
tasks:
informations: