Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing PostgreSQL support #1722

Closed
wants to merge 9 commits into from
Closed

Fixing PostgreSQL support #1722

wants to merge 9 commits into from

Conversation

danrot
Copy link
Contributor

@danrot danrot commented Oct 27, 2015

This branch is activating the build for PostgreSQL, which is currently failing. @carltongibson will create some Pull Requests targeted at this branch to fix this.

tasks:

  • test coverage
  • gather feedback for my changes
  • submit changes to the documentation

informations:

q a
Fixed tickets fixes #53
BC breaks hopefully none
Documentation PR none

@carltongibson
Copy link

Update:

Of the originally failing bundles, we're about half way there. #1720, #1725, #1726 fixes Categories, Contacts and Tags respectively. (@danrot: please review at your leisure.)

I have to pause until next week now but I will continue with MediaBundle. The queries here are more complex but, it is exhibiting the same semi-random failures as I found in #1725.

Here's one run:

.............F.....F..................................F.F......  63 / 108 ( 58%)
.............................................

And here's another one straight after:

.................................................F..FF.F.F.....  63 / 108 ( 58%)
.............................................

Same tests. Different failures. :-)

Again it'll just be a case of providing Postgres with the correct ordering. (There is an $orderBy parameter being passed around so I need to see exactly what's happening to that but I'm assuming it'll be a single change in the end.)

Having got this far without incident I'm optimistic that ResourcesBundle and SecurityBundle will prove relatively easy to resolve as well. (I haven't yet looked)

danrot and others added 8 commits January 20, 2016 16:58
Postgres doesn't share the default ordering by ID. We have to specify the ordering.

I'm not 100% certain as yet what the default ordering is but it's not stable with respect to `id` and, as such, we were getting different failures on different test runs. Fun!
Doctrine wraps DB specific error codes.
@danrot
Copy link
Contributor Author

danrot commented Jan 20, 2016

@carltongibson The progress already looks quite good, there aren't too many failing tests left. However, it would be good if we don't wait too long on finishing this, I've already seen a new feature failing some tests again 😕

@carltongibson
Copy link

@danrot Yeah — I didn't think I was far off. IIRC there were remaining ordering issues — with intermittent failures and that was about it.

(I thought ordering the relations may be all that's needed there — but didn't get to check that.)

Will say more in Feb! Ping me on anything relevant so I can keep up.

@danrot
Copy link
Contributor Author

danrot commented Aug 10, 2016

Replaced by #2703

@danrot danrot closed this Aug 10, 2016
@danrot danrot deleted the bugfix/postgres branch August 10, 2016 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date format
2 participants