[FEATURE] Added navigation context in structure #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
changed the title
wachterjohannes
changed the title
| @@ -640,7 +661,7 @@ public function loadStartPage($webspaceKey, $languageCode) | |||
| $startPage = $this->load($uuid, $webspaceKey, $languageCode); | |||
| $startPage->setNodeState(StructureInterface::STATE_PUBLISHED); | |||
| $startPage->setGlobalState(StructureInterface::STATE_PUBLISHED); | |||
| $startPage->setNavigation(true); | |||
| $startPage->setNavContexts(true); | |||
There was a problem hiding this comment.
@wachterjohannes Should here really be true passed? NavContexts are a string array.
|
Generally ok, but the navContexts variable confuses me a bit... What does it mean when it is a boolean? Shouldn't it always be a string array, with the option to be empty, if it's not shown in any navigation? |
…f/sulu into feature/navigation-context Conflicts: src/Sulu/Component/Content/Mapper/ContentMapper.php
6 tasks
alexander-schranz
pushed a commit
to alexander-schranz/sulu
that referenced
this pull request
Feb 22, 2024
* Add AudienceTargetingBundle Javascript * Remove registration of AudienceTargetingBundle * Add database as a service
alexander-schranz
added a commit
to alexander-schranz/sulu
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added navigation context in structure:
Tasks:
Informations: