POC RoutingAuto integration #1989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
force-pushed
the
routing_auto
branch
from
a09a0db
to
b153314
Compare
| 'path' => '/cmf/sulu_io/contents/foo' . $index | ||
| )); | ||
|
|
||
| $this->manager->flush(); |
There was a problem hiding this comment.
We can or cannot keep this - however it clocks in at 20op/s on my machine (would obviously be faster if we didn't flush on each op)
dantleech
force-pushed
the
routing_auto
branch
from
b153314
to
b97441f
Compare
| $this->assertTrue($route->isRedirect()); | ||
|
|
||
| // See https://github.com/symfony-cmf/RoutingAuto/issues/67 | ||
| $this->markTestSkipped('TODO: Bug in RoutingAuto component, see link above.'); |
There was a problem hiding this comment.
There is a bug in RoutingAuto here.
dantleech
force-pushed
the
routing_auto
branch
from
466263f
to
e7d5d70
Compare
|
@chirimoya one thing we will need to deal with is "caching" the URLs in the content for the menu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently an experimental branch for integrating the Symfony CMF RoutingAuto component.
Practically it:
Other benefits:
/products/my-product-nameRouteDocumentmore of a thing, paving the way to do things like{{ path(document) }}for path generation in Twig templates / etc.