-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added backdrop and stylelint rule #3468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two new lines, good work otherwise!
The Backdrop component serves as a simple solution to create a backdrop for modals and other kinds of overlays. | ||
|
||
Here is a basic example of the component. The open state of the backdrop is controlled by the `isOpen` property. | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New line before that
``` | ||
|
||
This time the `isVisible` property is set to false, therefore the backdrop is invisible. | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New line before that
I didn't ask you to remove the new lines, I've asked you to add some more 🙈 |
isVisible, | ||
onClick, | ||
} = this.props; | ||
const backdropClasses = classNames({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add new empty line
ACK |
What's in this PR?
A backdrop component and a styleguide rule.
Why?
Because we the UI needs a backdrop.
Example Usage
To Do