Added extension-guesser to fix wrong extensions on download #3720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
hotfix/media-incorrect-extension
branch
2 times, most recently
from
2fa9c22
to
1b2b51f
Compare
alexander-schranz
requested changes
Jan 23, 2018
|
|
||
| public function testDownloadWithDotInName() | ||
| { | ||
| $filePath = $this->createMediaFile('fitness-seasons.agency--C-&-C--Rodach,-Johannes.jpg'); |
There was a problem hiding this comment.
add test case with this name but without .jpg extension.
wachterjohannes
force-pushed
the
hotfix/media-incorrect-extension
branch
from
1b2b51f
to
329e69b
Compare
alexander-schranz
approved these changes
Jan 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR fixes an error in download when the filename contains a wrong extension.