Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FieldType for internal links #3855

Merged
merged 13 commits into from Apr 3, 2018
Merged

Conversation

danrot
Copy link
Contributor

@danrot danrot commented Mar 19, 2018

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #---
Related issues/PRs #---
License MIT
Documentation PR ---

What's in this PR?

This PR will add a new field type for the internal_links content type.

Why?

Because this field type has also to work in the new UI.

To Do

  • Create a documentation PR
  • Reopen overlay fails because of active item (what should be open when reopening in general?)
  • How to handle media selection overlay in regard of width?
  • Fix scrolling in overlay when x-axis can also be scrolled
  • Error message for handling linking page to itself
  • Issue for different Homepage title (webspace name vs "Homepage")
  • Add translations
  • Adapt overlays as in design
  • Implement selectable in all adapters

@danrot danrot added the Feature New functionality not yet included in Sulu label Mar 19, 2018
@danrot danrot added this to the Release 2.0 milestone Mar 19, 2018
@danrot danrot force-pushed the feature/internal-links branch 5 times, most recently from 46207af to 3be4380 Compare March 20, 2018 14:01
@danrot danrot mentioned this pull request Mar 20, 2018
2 tasks
@danrot danrot force-pushed the feature/internal-links branch 2 times, most recently from f044bd9 to 134a051 Compare March 26, 2018 15:10
add different predefined sizes for overlay

fix columns without toolbar

add internal link content type with other datagrid adapter

fix minor bug with wrong border radius on column list toolbar with single item
@@ -44,6 +44,7 @@ function registerFieldTypes() {

// TODO move to correct bundle or even allow to register somehow via the config request
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding the assignments via the server config is also something we should do in the near future.

overflow: hidden;
}

.adapter-column_list {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.adapter.column_list

@chirimoya chirimoya merged commit 7bd7286 into sulu:develop Apr 3, 2018
@danrot danrot deleted the feature/internal-links branch April 3, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants