New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FieldType for internal links #3855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrot
force-pushed
the
feature/internal-links
branch
5 times, most recently
from
March 20, 2018 14:01
46207af
to
3be4380
Compare
2 tasks
danrot
force-pushed
the
feature/internal-links
branch
2 times, most recently
from
March 26, 2018 15:10
f044bd9
to
134a051
Compare
add different predefined sizes for overlay fix columns without toolbar add internal link content type with other datagrid adapter fix minor bug with wrong border radius on column list toolbar with single item
danrot
force-pushed
the
feature/internal-links
branch
from
March 27, 2018 10:52
134a051
to
aedd87e
Compare
danrot
force-pushed
the
feature/internal-links
branch
from
March 27, 2018 15:23
cd32046
to
f0bd2d2
Compare
danrot
force-pushed
the
feature/internal-links
branch
from
March 28, 2018 11:30
f0bd2d2
to
4c5b775
Compare
danrot
force-pushed
the
feature/internal-links
branch
from
March 28, 2018 17:26
81f1328
to
3875d35
Compare
danrot
force-pushed
the
feature/internal-links
branch
from
March 29, 2018 06:34
3875d35
to
b4e501e
Compare
danrot
commented
Mar 29, 2018
@@ -44,6 +44,7 @@ function registerFieldTypes() { | |||
|
|||
// TODO move to correct bundle or even allow to register somehow via the config request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding the assignments via the server config is also something we should do in the near future.
1 task
chirimoya
requested changes
Apr 3, 2018
overflow: hidden; | ||
} | ||
|
||
.adapter-column_list { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.adapter.column_list
chirimoya
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR will add a new field type for the
internal_links
content type.Why?
Because this field type has also to work in the new UI.
To Do