Fix bug in Requester for nested objects #4460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trickreich
force-pushed
the
bugfix/requester-nested-objects
branch
from
c3c24d4
to
cd8571a
Compare
trickreich
added
the
Bug
trickreich
force-pushed
the
bugfix/requester-nested-objects
branch
2 times, most recently
from
6907585
to
cb31a6f
Compare
|
The |
trickreich
force-pushed
the
bugfix/requester-nested-objects
branch
from
fe2ff7f
to
bfd7923
Compare
|
@danrot Should be working again. |
danrot
reviewed
Mar 4, 2019
src/Sulu/Bundle/AdminBundle/Resources/js/services/Requester/Requester.js
Outdated
Show resolved
Hide resolved
danrot
reviewed
Mar 4, 2019
src/Sulu/Bundle/AdminBundle/Resources/js/services/Requester/tests/Requester.test.js
Outdated
Show resolved
Hide resolved
Fix js lint Fix bug when data is an observable Improve handling of observables do not use toJS Check for observable arrays Correct if statement Fix import Fix import order Fix linting
trickreich
force-pushed
the
bugfix/requester-nested-objects
branch
from
60db54e
to
f786fb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix bug in Requester for nested objects.
Why?
Because
undefinedis not converted tonullcurrently, therefore the property will not be included in the payload.