New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ExternalLink for CKEditor #4487
Merged
chirimoya
merged 15 commits into
sulu:develop
from
danrot:feature/ckeditor-external-link
Mar 20, 2019
Merged
Implement ExternalLink for CKEditor #4487
chirimoya
merged 15 commits into
sulu:develop
from
danrot:feature/ckeditor-external-link
Mar 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrot
force-pushed
the
feature/ckeditor-external-link
branch
2 times, most recently
from
March 20, 2019 07:03
d27edc7
to
39d4a71
Compare
danrot
force-pushed
the
feature/ckeditor-external-link
branch
from
March 20, 2019 07:11
39d4a71
to
73d374f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds the possibility to add an external link in the CKEditor.
Why?
Because this functionality is used very often.