Fix copying of teaser selection in WebspaceCopyCommand #4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
process teaser_selection content type
alexander-schranz
requested changes
May 7, 2019
There was a problem hiding this comment.
@debreczeniandras thank you for your pull request can you add a check to do this only for the page teaser type?
alexander-schranz
added
the
Bug
limit teaser_selection types to 'content'
alexander-schranz
changed the title
|
@debreczeniandras and can you update your branch to the current master branch and add a line to the |
check existence of property
alexander-schranz
approved these changes
May 15, 2019
|
Shouldn't we also add a test for this? 🤔 |
|
Thank you @debreczeniandras |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Process teaser_selection content type.
To Do