Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect to locale-prefix for partial match requests #4672

Merged

Conversation

wachterjohannes
Copy link
Member

@wachterjohannes wachterjohannes commented Aug 8, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs none
License MIT
Documentation PR none

What's in this PR?

This PR add redirects to locale-prefix for partial match requests. As already implemented for pages.

Why?

For example articles are exposed as /articles/article-1 and /de/articles/article-1.

To Do

  • Tests
  • Add breaking changes to UPGRADE.md

@wachterjohannes wachterjohannes force-pushed the bugfix/non-locale-route branch 2 times, most recently from b9fef24 to 22e05c1 Compare August 9, 2019 07:20
@wachterjohannes wachterjohannes changed the base branch from develop to release/1.5 August 9, 2019 07:20
@wachterjohannes wachterjohannes marked this pull request as ready for review August 9, 2019 07:22
@wachterjohannes wachterjohannes force-pushed the bugfix/non-locale-route branch 5 times, most recently from 288d51d to 890532e Compare August 9, 2019 12:12
@wachterjohannes
Copy link
Member Author

@alexander-schranz this is also ready to review

@alexander-schranz alexander-schranz changed the base branch from release/1.5 to master September 18, 2019 21:30
@alexander-schranz alexander-schranz added the Bug Error or unexpected behavior of already existing functionality label Sep 18, 2019
@alexander-schranz alexander-schranz added this to the Release 1.6 milestone Sep 18, 2019
UPGRADE.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants