Update to latest JS packages #4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
requested changes
Aug 29, 2019
danrot
force-pushed
the
feature/package-updates
branch
from
bf75756
to
575a55d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR updates all the JS dependencies to their latest version. The only exception is mobx, because if we update it, it will not be compatible with IE11 anymore. However, this PR still removes all the polyfills required by IE11. The reasoning behind this is, that CKEditor5 is not working with IE11 at the moment anyway.
We can add the polyfills when continue to work on #4704, but it doesn't make sense as long as CKEditor is blocking it.
Why?
Because if we update to latest packages now we have less to support later.