Pass the exception in the logger context #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tstauer thx for the pull request can you rebase your branch to |
tstauer
force-pushed
the
feature/log-exception
branch
from
b2f8826
to
ad5dcd4
Compare
tstauer
force-pushed
the
feature/log-exception
branch
from
ad5dcd4
to
0c80719
Compare
|
@alexander-schranz: I've updated the pull request. |
|
@tstauer thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Pass the exception in the FormatManager to the LoggerInterface.
https://www.php-fig.org/psr/psr-3/#13-context describes how it is done.
https://github.com/symfony/console/blob/master/EventListener/ErrorListener.php#L48 shows that symfony may pass an exception as context.
Why?
I want to ignore a MediaNotFoundException on a staging system.
Without passing the exception one has to interpret the error message string instead which is inconvenient and perhaps not reliable.
BC Breaks/Deprecations
The stack trace is no longer logged as context. One can get that from the exception instead.
To Do