Do not select disabled items when select-all checkbox in List is clicked #5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasnatter
force-pushed
the
feature/select-all-disabled
branch
2 times, most recently
from
2b9b49f
to
d93ab9d
Compare
niklasnatter
force-pushed
the
feature/select-all-disabled
branch
from
d93ab9d
to
32ec7b0
Compare
danrot
suggested changes
Jan 28, 2020
src/Sulu/Bundle/AdminBundle/Resources/js/components/Table/tests/Table.test.js
Outdated
Show resolved
Hide resolved
danrot
reviewed
Jan 28, 2020
danrot
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adjusts the behaviour of the
Listcontainer to only select non-disabled items if theonAllSelectionChangecallback is fired by aListAdapter(for example when the select-all checkbox of theTableAdapteris clicked).Furthermore, this PR fixes a bug that rendered the select-all checkbox of the
TableAdapterwith the wrong skin. Also, the select-all checkbox of theTableAdapteris now rendered as checked if all non-disabled rows are selected.Why?
Because the goal of disabling items is that they cannot get selected.. 馃槈