Add disable and visible condition to TypeToolbarAction #5007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...lu/Bundle/AdminBundle/Resources/js/views/Form/tests/toolbarActions/TypeToolbarAction.test.js
Outdated
Show resolved
Hide resolved
alexander-schranz
force-pushed
the
enhancement/disable-type-toolbar
branch
from
5bd4ae7
to
7683bc8
Compare
src/Sulu/Bundle/AdminBundle/Resources/js/views/Form/toolbarActions/TypeToolbarAction.js
Outdated
Show resolved
Hide resolved
|
should we use the |
|
@nnatter PageAdmin doesn't use the TypeToolbarAction it seems to have its own TemplateToolbarAction. |
alexander-schranz
force-pushed
the
enhancement/disable-type-toolbar
branch
from
b69bf2f
to
57c12e3
Compare
alexander-schranz
force-pushed
the
enhancement/disable-type-toolbar
branch
2 times, most recently
from
c1abeab
to
0e340f5
Compare
danrot
suggested changes
Jan 29, 2020
src/Sulu/Bundle/AdminBundle/Resources/js/views/Form/toolbarActions/TypeToolbarAction.js
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/PageBundle/Resources/js/views/Form/toolbarActions/TemplateToolbarAction.js
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/PageBundle/Resources/js/views/Form/toolbarActions/TemplateToolbarAction.js
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/AdminBundle/Resources/js/views/Form/toolbarActions/TypeToolbarAction.js
Outdated
Show resolved
Hide resolved
alexander-schranz
force-pushed
the
enhancement/disable-type-toolbar
branch
from
58830d3
to
0225d6a
Compare
alexander-schranz
force-pushed
the
enhancement/disable-type-toolbar
branch
from
0225d6a
to
0e32939
Compare
|
@danrot @nnatter comments fixed. |
danrot
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add disable and visible condition to TypeToolbarAction.
Why?
Allows to hide or disable TypeToolbarAction.
To Do