Add CI lint container in different environments #5339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
bugfix/lint-different-env-container
branch
2 times, most recently
from
6fd81eb
to
ad9babe
Compare
|
👍, but would wait until symfony/symfony#37166 is fixed before merging that. |
alexander-schranz
force-pushed
the
bugfix/lint-different-env-container
branch
from
ad9babe
to
ac16fa5
Compare
|
@danrot The Symfony issue is fixed now. |
|
@alexander-schranz I restarted the tests, and they are failing for a different reason now. Can you check? |
danrot
force-pushed
the
bugfix/lint-different-env-container
branch
from
6f67e19
to
0b7158e
Compare
danrot
force-pushed
the
bugfix/lint-different-env-container
branch
from
0b7158e
to
f9f267d
Compare
|
@alexander-schranz Is that good to merge now? |
|
@danrot yes as symfony/symfony#37166 is released there should be no problems. |
|
@alexander-schranz I am asking because I've updated the branch one more time, and so it is actually your task to merge it 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Lint container in different environments.
Why?
Currently it seems linting failed on prod env on skeleton. To avoid this we should also lint this in sulu/sulu so we get feedback as soon as possible when sulu/sulu container is not correct in an environment.