Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qrcode field type #6506

Merged
merged 4 commits into from
Apr 13, 2022
Merged

Add qrcode field type #6506

merged 4 commits into from
Apr 13, 2022

Conversation

wachterjohannes
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs none
License MIT
Documentation PR none

What's in this PR?

This PR integrates a QR-Code library into the form.

Why?

Can be used to generate QR-Codes in the form.

Example Usage

@wachterjohannes wachterjohannes force-pushed the qrcode-field branch 3 times, most recently from 810b301 to a942e92 Compare March 14, 2022 08:34
@wachterjohannes wachterjohannes changed the base branch from 2.x to 2.4 March 14, 2022 08:35
@wachterjohannes wachterjohannes force-pushed the qrcode-field branch 2 times, most recently from 034ab92 to d1199f1 Compare March 14, 2022 08:42
@wachterjohannes wachterjohannes marked this pull request as ready for review March 17, 2022 06:06
@alexander-schranz alexander-schranz added the Feature New functionality not yet included in Sulu label Mar 17, 2022
@alexander-schranz alexander-schranz changed the base branch from 2.4 to 2.x March 17, 2022 19:13
alexander-schranz
alexander-schranz approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@alexander-schranz alexander-schranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. Should we add a content type for it? And add some docs for our content type documentation.

I will test it with the current project to check the design and how it looks like in different formats / grid sizes.

@alexander-schranz alexander-schranz enabled auto-merge (squash) April 7, 2022 14:48
@alexander-schranz alexander-schranz changed the title Add qrcode field Add qrcode field type Apr 7, 2022
@alexander-schranz alexander-schranz force-pushed the qrcode-field branch 2 times, most recently from 5050d13 to 9977393 Compare April 7, 2022 15:08
@alexander-schranz alexander-schranz merged commit 55e8d43 into sulu:2.5 Apr 13, 2022
@wachterjohannes wachterjohannes deleted the qrcode-field branch April 13, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz approved these changes

Assignees
No one assigned
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wachterjohannes @alexander-schranz