Upgrade Symfony calls to MAIN_REQUEST, LogoutEvent, TestUserProvider, Kernel RoutingConfigurator #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
enhancement/symfony-deprecations
branch
2 times, most recently
from
46cb722
to
2543b7d
Compare
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
enhancement/symfony-deprecations
branch
from
2543b7d
to
e24e8a9
Compare
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
enhancement/symfony-deprecations
branch
2 times, most recently
from
8254d8b
to
9f407b1
Compare
| @@ -41,6 +41,6 @@ public function dispatchDomainEventWithSpecificEventName(DomainEvent $event): vo | |||
| // allows to register listeners that listen to all domain events. | |||
| // this subscriber additionally dispatches the event with a specific event-name such as TagRemovedEvent::class | |||
| // to allow for registering listeners for a specific type of event. | |||
| $this->eventDispatcher->dispatch($event, \get_class($event)); | |||
There was a problem hiding this comment.
get_class is the default behaviour of the event dispatcher that is why rector is replacing it.
| @@ -35,12 +35,12 @@ public function __construct(TranslatorInterface $translator) | |||
| /** | |||
| * @param mixed[] $parameters | |||
| */ | |||
| public function trans($id, array $parameters = [], $domain = null, $locale = null): string | |||
| public function trans(string $id, array $parameters = [], string $domain = null, string $locale = null): string | |||
There was a problem hiding this comment.
this class is @internal and should so make no difference here.
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
enhancement/symfony-deprecations
branch
from
9f407b1
to
257b9fd
Compare
84 tasks
alexander-schranz
force-pushed
the
enhancement/symfony-deprecations
branch
from
257b9fd
to
ecb3e1d
Compare
Prokyonn
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Upgrade deprecated symfony method calls.
Why?
To make sulu compatible with symfony 6 in future.