Replace deprecated self::$container with self::getContainer() in tests #6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * This function exist to keep compatibility to old tests. | ||
| */ | ||
| protected static function getContainer(): ContainerInterface |
There was a problem hiding this comment.
This conflicts with the symfony getContainer method and so need to be removed. Symfony ships the same implementation now https://github.com/symfony/symfony/blob/d11e41be6cb23016894c564d5c2b9ef3357ecaa7/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php#L100
alexander-schranz
added
the
Bug
84 tasks
alexander-schranz
force-pushed
the
enhancement/test-get-container
branch
from
3c0aa79
to
f49c13b
Compare
alexander-schranz
force-pushed
the
enhancement/test-get-container
branch
from
f49c13b
to
8094682
Compare
alexander-schranz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Replace deprecated self:: with self::getContainer() in tests
Why?
The
self::$containerwas removed and the container is now provided over symfonygetContainermethod.