Make a clone of symfony 5.4 RegisterListenersPass for usage in DocumentManagerBundle #6579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
enhancement/event-dispatcher-compatibility
branch
from
8e0477b
to
6e2eb7c
Compare
84 tasks
alexander-schranz
force-pushed
the
enhancement/event-dispatcher-compatibility
branch
3 times, most recently
from
4397208
to
30cbd6c
Compare
alexander-schranz
force-pushed
the
enhancement/event-dispatcher-compatibility
branch
from
30cbd6c
to
e38a2a3
Compare
| * This is a copy of the Symfony 5.4 EventDispatcher RegisterListenersPass as it is not available this way in Symfony 6. | ||
| * https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php | ||
| */ | ||
| class RegisterListenersPass implements CompilerPassInterface |
There was a problem hiding this comment.
This is just a copy of (v5.4.8): https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php
Because they refractored it in Symfony 6 so we could not longer use it for our document event dispatcher as they hardcoded the service definitions.
Prokyonn
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Make a clone of symfony 5.4 RegisterListenersPass for usage in DocumentManagerBundle.
Why?
For future symfony 6 compatibility. There the
RegisterListenersPasswas refractored and can not longer be used the way we using it here.