Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatiblity of CollaborationControllerTest for Symfony 6 #6586

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented May 3, 2022

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #
Related issues/PRs #6556
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Add compatiblity of CollaborationControllerTest for Symfony 6.

Why?

For Future Symfony 6 compatibility.

@alexander-schranz alexander-schranz force-pushed the enhancement/collaboration-controller-compatibility branch from c8948f7 to a5d33b9 Compare May 3, 2022 16:14
@alexander-schranz alexander-schranz added the DX Affecting the end developer label May 3, 2022
@alexander-schranz alexander-schranz mentioned this pull request May 3, 2022
84 tasks
@alexander-schranz alexander-schranz force-pushed the enhancement/collaboration-controller-compatibility branch from a5d33b9 to e0e83b4 Compare May 3, 2022 16:42
@@ -5,6 +5,8 @@ security:
- { path: ^/admin/login, roles: IS_AUTHENTICATED_ANONYMOUSLY }
- { path: ^/admin, roles: ROLE_USER }

session_fixation_strategy: none # required for the CollaborationControllerTest
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without it was not able to get the test running which manipulates the session

@Prokyonn Prokyonn merged commit 5718183 into sulu:2.5 May 3, 2022
alexander-schranz added a commit to alexander-schranz/sulu that referenced this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants