-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2FA authentication via scheb/2fa #6589
Merged
wachterjohannes
merged 41 commits into
sulu:2.5
from
alexander-schranz:feature/scheb-2fa
Jun 24, 2022
Merged
Add 2FA authentication via scheb/2fa #6589
wachterjohannes
merged 41 commits into
sulu:2.5
from
alexander-schranz:feature/scheb-2fa
Jun 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90d71f2
to
686a506
Compare
1d6d47a
to
f806f37
Compare
Closed
@alexander-schranz, nice feature ;) |
c18c28a
to
167019b
Compare
@matthieu2607 Thx it does look good that we will get this into Sulu 2.5. Already preparing the frontend for 2fa codes: Emails already send with the code, but need to implement the success handlers and check endpoints. Maybe will get a running prototype next week. |
377a50f
to
065309b
Compare
065309b
to
7754047
Compare
f117286
to
972f3ab
Compare
f808f4a
to
35177ba
Compare
0e8d65e
to
04457be
Compare
wachterjohannes
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add 2fa authentication via scheb/2fa.
Why?
Supporting two factor authentication.
Example Usage
To Do
TypeMethodBackup Codes should never be outputted by the APIAs discussed all twoFactorOptions should be encrypted / decrypt need to be lazy as it should not effect performance as user is loaded every request.canceledQR Code (totp, google authenticator)TotpGoogle AuthenticatorBackup Codes