Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account deletion by setting parent account references to null #6605

Merged
merged 2 commits into from May 23, 2022
Merged

Fix account deletion by setting parent account references to null #6605

merged 2 commits into from May 23, 2022

Conversation

ymc-siwi
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #6600 (partially)
Related issues/PRs none
License MIT

What's in this PR?

Will set on-delete="SET NULL" for parent organization references in organizations; Current solution will default to on-delete=„PROTECT“; This will cause failing foreign key constraints when deleting organizations with broken references - the references are protected and will not be deleted/cleaned up properly.

Why?

For detailed description see #6600

@alexander-schranz alexander-schranz changed the title Fixed setting parent account references to null on delete Fix account deletion by setting parent account references to null May 16, 2022
@alexander-schranz alexander-schranz added the Bug Error or unexpected behavior of already existing functionality label May 16, 2022
ymc-siwi and others added 2 commits May 23, 2022 15:59
For detailed description see #6600; Will avoid defaulting to on-delete=„PROTECT“ causing failing foreign key constraints
@alexander-schranz alexander-schranz merged commit 904787e into sulu:2.3 May 23, 2022
@alexander-schranz
Copy link
Member

@ymc-siwi Thank you!

@ymc-siwi
Copy link
Contributor Author

@alexander-schranz Cheers for the quick reaction and finalization :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants