Implement block action for copying and cutting a single block #6630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasnatter
commented
May 30, 2022
| } | ||
|
|
||
| if (value) { | ||
| // TODO: gracefully handle clipboard data this is incompatible with available block types |
There was a problem hiding this comment.
i have not tested this at all yet
niklasnatter
force-pushed
the
feature/block-copy-paste
branch
from
7843bf4
to
85695f1
Compare
alexander-schranz
requested changes
May 30, 2022
src/Sulu/Bundle/AdminBundle/Resources/js/components/BlockCollection/BlockCollection.js
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/AdminBundle/Resources/js/stores/clipboardStore/clipboardStore.js
Outdated
Show resolved
Hide resolved
niklasnatter
force-pushed
the
feature/block-copy-paste
branch
from
85695f1
to
5bcc782
Compare
alexander-schranz
added
Feature
niklasnatter
force-pushed
the
feature/block-copy-paste
branch
2 times, most recently
from
c288a7c
to
b48b059
Compare
alexander-schranz
force-pushed
the
feature/block-copy-paste
branch
from
b48b059
to
bbbdd01
Compare
alexander-schranz
force-pushed
the
feature/block-copy-paste
branch
from
c7a940c
to
c2ff373
Compare
Comment on lines
53
to
54
| this.fillArraysDisposer = reaction(() => this.props.value.length, this.fillArrays, {fireImmediately: true}); | ||
| this.fillArraysDisposer = reaction(() => this.props.value.length, this.fillArrays, {fireImmediately: true}); |
There was a problem hiding this comment.
Is this expected to be duplicated?
src/Sulu/Bundle/AdminBundle/Resources/js/components/BlockCollection/BlockCollection.js
Outdated
Show resolved
Hide resolved
…ction/BlockCollection.js
3 tasks
alexander-schranz
approved these changes
Jun 9, 2022
This was referenced Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This pull request adds a
copyand acutaction for blocks. The implementation builds upon the HTMLlocalStorageto allow for copying blocks from one browser window into another browser window.