Remove not longer existing Kernel Root Dir #6652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 tasks
alexander-schranz
requested review from
wachterjohannes
and removed request for
wachterjohannes
alexander-schranz
force-pushed
the
enhancement/remove-deprecate-kernel-root-dir
branch
from
3c5bd0c
to
a7e1d8d
Compare
| @@ -60,26 +55,20 @@ protected function getContainerClass(): string | |||
| return $this->generateContainerClass(\get_parent_class()); | |||
| } | |||
|
|
|||
| public function getRootDir(/* $triggerDeprecation = true */) | |||
| public function getProjectDir(): string | |||
There was a problem hiding this comment.
update with the changes from symfony core
| @@ -60,26 +55,20 @@ protected function getContainerClass(): string | |||
| return $this->generateContainerClass(\get_parent_class()); | |||
| } | |||
|
|
|||
| public function getRootDir(/* $triggerDeprecation = true */) | |||
There was a problem hiding this comment.
removed as not longer needed and was deprecated since symfony 4.2, but was required as we did support symfony 4.4 until 2.4
alexander-schranz
deleted the
enhancement/remove-deprecate-kernel-root-dir
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove not longer existing Kernel Root Dir
Why?
Deprecated since symfony 4 and removed in symfony 5 the kernel root dir should now be possible to be removed safely from our methods.