Add BlockToolbar for copy, remove, cut, duplicate multiple selected blocks #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/block-toolbar
branch
from
9fdb6ab
to
8b28f35
Compare
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
feature/block-toolbar
branch
2 times, most recently
from
555445c
to
3e7d91f
Compare
This was referenced Jun 30, 2022
Merged
Merged
alexander-schranz
force-pushed
the
feature/block-toolbar
branch
5 times, most recently
from
d822753
to
7752751
Compare
alexander-schranz
force-pushed
the
feature/block-toolbar
branch
from
f26dac8
to
3df1fdb
Compare
alexander-schranz
requested review from
wachterjohannes
and removed request for
wachterjohannes
alexander-schranz
force-pushed
the
feature/block-toolbar
branch
2 times, most recently
from
772caa4
to
148eb93
Compare
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
feature/block-toolbar
branch
from
cf9eab8
to
590ad70
Compare
alexander-schranz
force-pushed
the
feature/block-toolbar
branch
from
590ad70
to
35790c9
Compare
alexander-schranz
force-pushed
the
feature/block-toolbar
branch
from
17aea33
to
17f2b51
Compare
alexander-schranz
force-pushed
the
feature/block-toolbar
branch
from
5f0b73c
to
9b8df87
Compare
alexander-schranz
force-pushed
the
feature/block-toolbar
branch
from
c46abed
to
bf14d13
Compare
luca-rath
suggested changes
Jul 7, 2022
src/Sulu/Bundle/AdminBundle/Resources/js/components/BlockCollection/SortableBlockList.js
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/AdminBundle/Resources/js/components/BlockCollection/types.js
Outdated
Show resolved
Hide resolved
luca-rath
reviewed
Jul 7, 2022
src/Sulu/Bundle/AdminBundle/Resources/js/components/BlockCollection/BlockCollection.js
Show resolved
Hide resolved
|
Another thing: Personally I would expect that the BlockToolbar disappears, when the user either unselect all items or finishes an action, but I guess a UX expert should decide that |
Co-authored-by: Luca Rath-Heel <luca-rath@hotmail.com>
…ction/SortableBlockList.js Co-authored-by: Luca Rath-Heel <luca-rath@hotmail.com>
|
@luca-rath yeah I'm also not sure about behaviour after some action. But @chirimoya said he will have a look at it then. So I think we will merge it with the current state and so @chirimoya can test it then. |
luca-rath
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add blocktoolbar for multi copy and paste functionality
Why?
Multiple blocks should be able to be copied and pasted.