-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ckeditor to version 34.2.0 and postcss to version 8 #6688
Upgrade ckeditor to version 34.2.0 and postcss to version 8 #6688
Conversation
05a0490
to
c3030a0
Compare
c3030a0
to
9e89ac2
Compare
if (disabled) { | ||
this.editorInstance.enableReadOnlyMode('disabled'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 ways of getting this merged. First would be create a fork of the used postcss plugin based on existi compatible pull request here: madeleineostoja/postcss-hexrgba#33 I personally would go with fork exist postcss-hexrgba package. /cc @sulu/core-team |
Looks like madeleineostoja/postcss-hexrgba#33 was merged a few hours ago, so we dont need to fork 🥳 |
Co-authored-by: niklasnatter <niklas.natter@gmail.com>
What's in this PR?
Upgrade ckeditor to version 34.2.0.
Why?
Supporting the latest ckeditor features and plugins.
TODO
rgba($
do not longer work