Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy-snippet button in form #6859

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

wachterjohannes
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #6609
Related issues/PRs none
License MIT
Documentation PR none

What's in this PR?

This PR add the copy button to the snippet form

@wachterjohannes wachterjohannes force-pushed the copy-snippet branch 3 times, most recently from dafad36 to 28561f4 Compare October 20, 2022 09:08
@wachterjohannes wachterjohannes marked this pull request as ready for review October 20, 2022 10:48
@alexander-schranz alexander-schranz added the Feature New functionality not yet included in Sulu label Oct 21, 2022
@wachterjohannes
Copy link
Member Author

@alexander-schranz have extracted the php-cs fixes and phpstan fixes into an own PR #6862

@wachterjohannes wachterjohannes force-pushed the copy-snippet branch 4 times, most recently from 907d499 to 01d1ea9 Compare October 24, 2022 07:09
@wachterjohannes
Copy link
Member Author

@alexander-schranz ping

Co-authored-by: Alexander Schranz <alexander@sulu.io>
@wachterjohannes
Copy link
Member Author

@alexander-schranz resolved

Copy link
Member

@alexander-schranz alexander-schranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected code style changes. if we change code style we need todo it on 2.4 / 2.5 via php-cs-fixer

src/Sulu/Bundle/SnippetBundle/Admin/SnippetAdmin.php Outdated Show resolved Hide resolved
src/Sulu/Bundle/SnippetBundle/Admin/SnippetAdmin.php Outdated Show resolved Hide resolved
src/Sulu/Bundle/SnippetBundle/Admin/SnippetAdmin.php Outdated Show resolved Hide resolved
src/Sulu/Bundle/SnippetBundle/Admin/SnippetAdmin.php Outdated Show resolved Hide resolved
src/Sulu/Bundle/SnippetBundle/Admin/SnippetAdmin.php Outdated Show resolved Hide resolved
src/Sulu/Bundle/SnippetBundle/Admin/SnippetAdmin.php Outdated Show resolved Hide resolved
src/Sulu/Bundle/SnippetBundle/Admin/SnippetAdmin.php Outdated Show resolved Hide resolved
src/Sulu/Bundle/SnippetBundle/Admin/SnippetAdmin.php Outdated Show resolved Hide resolved
Co-authored-by: Alexander Schranz <alexander@sulu.io>
@wachterjohannes
Copy link
Member Author

@alexander-schranz fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants