-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy-snippet button in form #6859
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
copy-snippet
branch
3 times, most recently
from
October 20, 2022 09:08
dafad36
to
28561f4
Compare
wachterjohannes
force-pushed
the
copy-snippet
branch
from
October 21, 2022 06:32
28561f4
to
1c319ba
Compare
@alexander-schranz have extracted the php-cs fixes and phpstan fixes into an own PR #6862 |
wachterjohannes
force-pushed
the
copy-snippet
branch
4 times, most recently
from
October 24, 2022 07:09
907d499
to
01d1ea9
Compare
wachterjohannes
force-pushed
the
copy-snippet
branch
from
October 24, 2022 07:45
01d1ea9
to
3609543
Compare
@alexander-schranz ping |
Co-authored-by: Alexander Schranz <alexander@sulu.io>
@alexander-schranz resolved |
alexander-schranz
requested changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected code style changes. if we change code style we need todo it on 2.4 / 2.5 via php-cs-fixer
src/Sulu/Bundle/SnippetBundle/Tests/Unit/Admin/SnippetAdminTest.php
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/SnippetBundle/Tests/Unit/Admin/SnippetAdminTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Schranz <alexander@sulu.io>
@alexander-schranz fixed |
alexander-schranz
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR add the copy button to the snippet form