Add page resource segment to PageRemovedEvent #6906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvasiloi
force-pushed
the
feature/6198
branch
from
09892d7
to
6acf3de
Compare
There was a problem hiding this comment.
@vvasiloi Thank you for working on this. Just some small comments.
src/Sulu/Bundle/PageBundle/Tests/Unit/EventListener/DomainEventSubscriberTest.php
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/PageBundle/Tests/Unit/EventListener/DomainEventSubscriberTest.php
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/PageBundle/Tests/Unit/EventListener/DomainEventSubscriberTest.php
Outdated
Show resolved
Hide resolved
…ared in parent classes
vvasiloi
force-pushed
the
feature/6198
branch
from
ea4f5f0
to
7280f7e
Compare
vvasiloi
force-pushed
the
feature/6198
branch
from
7280f7e
to
e34c7f0
Compare
|
@alexander-schranz I think it's ready. I looked to add some docs, but I didn't find any for spefic events, so I don't know where to start. 😅 |
alexander-schranz
approved these changes
Nov 25, 2022
|
@vvasiloi thx for the pull request. great work 👍 Yeah the events are really leaking. We shoul ddefinitly add a Events section to all the bundles to show and describe them. |
|
Hi @vvasiloi, just wanted to let you know how impressed I am about your methodical approach on this and the quality of the entire pull request, even if you have never worked with Sulu before. Thanks for your contribution! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
Use mocking in test (phpspec/prophecy)Not necessaryCreate a documentation PRThere's no documentation for particular events