Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for avif image formats #6910

Conversation

vinceAmstoutz
Copy link
Contributor

@vinceAmstoutz vinceAmstoutz commented Nov 20, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #6476
License MIT

What's in this PR?

Support for AVIF image formats.

Why?

Support for AVIF image formats for best traffic performance.

To Do

  • Create a documentation PR

@alexander-schranz alexander-schranz added the Feature New functionality not yet included in Sulu label Nov 21, 2022
@alexander-schranz
Copy link
Member

@vinceAmstoutz that looks great. Would be great if you could also create a Pull Request for the sulu/skeleton and the sulu/sulu-docs to add the new avif_quality configuration to them:

@vinceAmstoutz
Copy link
Contributor Author

@vinceAmstoutz that looks great. Would be great if you could also create a Pull Request for the sulu/skeleton and the sulu/sulu-docs to add the new avif_quality configuration to them:

@alexander-schranz You can found :

@alexander-schranz
Copy link
Member

alexander-schranz commented Nov 22, 2022

@vinceAmstoutz this looks great. Thank you! If possible it would be nice that we create also a test for the getSupportedOutputImageFormats method seems currently that method has no tests yet in the ImagineImageConverterTest.php. Let me know if you have time for that, else I will try to tackle the tests there.

@alexander-schranz alexander-schranz changed the base branch from 2.5 to 2.6 November 25, 2022 09:43
@vinceAmstoutz
Copy link
Contributor Author

vinceAmstoutz commented Nov 25, 2022

@vinceAmstoutz this looks great. Thank you! If possible it would be nice that we create also a test for the getSupportedOutputImageFormats method seems currently that method has no tests yet in the ImagineImageConverterTest.php. Let me know if you have time for that, else I will try to tackle the tests there.

It's done! I just pushed a commit.

@alexander-schranz alexander-schranz changed the title Feature: add support for avif image formats Add support for avif image formats Nov 25, 2022
@alexander-schranz alexander-schranz merged commit 56643c1 into sulu:2.6 Nov 25, 2022
@alexander-schranz
Copy link
Member

@vinceAmstoutz Great work 👍 Thank you for providing this feature and write the tests for it.

@vinceAmstoutz
Copy link
Contributor Author

Thanks, with pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for avif image formats
2 participants