Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update js dependencies babel-loader, postcss, styleguidist and stylelint packages #6929

Merged

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Dec 6, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes parts of #6343
Related issues/PRs sulu/skeleton#202
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Update js dependencies.

Why?

Using latest version of our dependencies to provide feature and bugfix support.

@alexander-schranz alexander-schranz added the DX Affecting the end developer label Dec 6, 2022
@alexander-schranz alexander-schranz changed the title Update js dependencies Update js dependencies babel-loader, postcss, styleguidist and stylelint packages Dec 6, 2022
package.json Outdated
@@ -48,12 +48,12 @@
"@testing-library/user-event": "^14.2.5",
"@wojtekmaj/enzyme-adapter-react-17": "^0.6.1",
"autoprefixer": "^10.4.7",
"babel-jest": "^26.3.0",
"babel-loader": "^8.0.6",
"babel-jest": "^29.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont know if it makes a difference, but i think i would keep this on the same version as jest? unfortunately, we are stuck on jest@26 for now

@@ -48,12 +48,12 @@
"@testing-library/user-event": "^14.2.5",
"@wojtekmaj/enzyme-adapter-react-17": "^0.6.1",
"autoprefixer": "^10.4.7",
"babel-jest": "^26.3.0",
"babel-loader": "^8.0.6",
"babel-jest": "^26.6.3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed with @niklasnatter we need to keep babel-jest on ^26 as we are currently stuck with jest ^26 I require the latest version of ^26 here #6929

@niklasnatter niklasnatter merged commit 7482007 into sulu:2.6 Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants