Add Router Attributes to Form Request to ResourceTabs View

[alexander-schranz]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Fixed tickets	fixes #
Related issues/PRs	#
License	MIT
Documentation PR	sulu/sulu-docs#

What's in this PR?

Add Router Attributes to Form Request to ResourceTabs View

Why?

Currently the ResourceTabView is missing some important feature to set this kind of options.

TODO

• Add addRouterAttributesToFormRequest to createResourceTabViewBuilder
• Avoid duplicated logic

[ThomasStoevelaar]

With this change we see 3 GET requests when navigation to a Form view inside a ResourceTabs view like the edit form of a category. This doesn't happen when refreshing the page when you are already on the form.

If you are adding missing features to the ResourceTabs I think it's also a good idea to add setIdQueryParameter to the createResourceTabViewBuilder and pass the idQueryParameter to the ResourceStore in the ResourceTabs view component if set.

createResourceStore = () => {
    const options = {};
    if (this.locales) {
        options.locale = observable.box();
        this.router.bind('locale', options.locale);
    }

    if (this.resourceStore) {
        this.resourceStore.destroy();
    }

    const {
        router: {
            attributes,
            route: {
                options: {
                    idQueryParameter,
                    requestParameters = {},
                    routerAttributesToFormRequest = {},
                },
            },
        },
    } = this.props;

    const formStoreOptions = requestParameters ? requestParameters : {};

    Object.keys(toJS(routerAttributesToFormRequest)).forEach((key) => {
        const formOptionKey = routerAttributesToFormRequest[key];
        const attributeName = isNaN(key) ? key : routerAttributesToFormRequest[key];

        formStoreOptions[formOptionKey] = attributes[attributeName];
    });

    if (idQueryParameter) {
        this.resourceStore = new ResourceStore(this.resourceKey, this.id, options, formStoreOptions, idQueryParameter);
    } else {
        this.resourceStore = new ResourceStore(this.resourceKey, this.id, options, formStoreOptions);
    }
};

[alexander-schranz]

@sulu/core-team we need to discuss how we can avoid duplicated code here. The ResourceTabs.js is now reimplementing a lot logic we already implemented for the FormView.