Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media data provider datetime sorting #7012

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

Jupi007
Copy link
Contributor

@Jupi007 Jupi007 commented Feb 16, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #7011
License MIT

What's in this PR?

Allow the possibility to sort media by creation and update datetime.

Capture d’écran du 2023-02-16 11-32-16

Why?

Because it is a common expected feature to be able to sort media by datetime.

Tests and docs

Maybe I'm wrong, but I think this isn't require any tests nor docs update.
Looking at the other data providers test class, no ones are testing sorting.
And the docs aren't mention detailed sorting options.

@alexander-schranz alexander-schranz added the Feature New functionality not yet included in Sulu label Feb 16, 2023
@alexander-schranz
Copy link
Member

@Jupi007 Thank you, as a feature we should target here 2.6 branch. PHP Lint can currently be ignored.

@Jupi007
Copy link
Contributor Author

Jupi007 commented Feb 16, 2023

Oh, sorry I didn't know.
Let's see if change the base merging branch works.

Edit: worked fine.

@Jupi007 Jupi007 changed the base branch from 2.4 to 2.6 February 16, 2023 11:00
@alexander-schranz
Copy link
Member

alexander-schranz commented Feb 16, 2023

A rebase is required this should not be a lot of a problem from 2.4 to 2.6:

git remote add sulu git@github.com:sulu/sulu.git
git fetch sulu

git rebase -i sulu/2.6

git push yourremote yourbranch --force

Else the CI would still be based on 2.4 and we can not be sure if changes and added tests on 2.6 run correctly.

@alexander-schranz
Copy link
Member

PHP 8.1 is unrelated and a current Symfony issue and so can be ignored: symfony/symfony#49387

The Node 16 build is also unrelated and can also be ignored so looks fine from my side.

@alexander-schranz alexander-schranz merged commit 4e2ab03 into sulu:2.6 Feb 16, 2023
@Jupi007 Jupi007 deleted the issue-7011 branch February 16, 2023 12:10
@alexander-schranz alexander-schranz added this to the Release 2.6 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants