Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Symfony deprecation for not declaring getSupportedTypes on FlattenExceptionNormalizer #7089

Merged
merged 3 commits into from
Jun 24, 2023

Conversation

stollr
Copy link
Contributor

@stollr stollr commented Jun 5, 2023

Q A
Bug fix? deprecation fix for Symfony 7 support
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets
Related issues/PRs
License MIT

What's in this PR?

I have added a getSupportedTypes method to the FlattenExceptionNormalizer.

Why?

Classes that implement the Symfony\Component\Serializer\NormalizerInterface will require the getSupportedTypes method for Symfony >= 7.0.

Currently Symfony's phpunit-bridge reports a deprecation message.

Update:
In the Symfony docs you'll find the details about that method (see here).

@alexander-schranz alexander-schranz added the DX Affecting the end developer label Jun 24, 2023
@alexander-schranz alexander-schranz changed the title Fixed Symfony deprecation for not declaring getSupportedTypes on FlattenExceptionNormalizer Fix Symfony deprecation for not declaring getSupportedTypes on FlattenExceptionNormalizer Jun 24, 2023
@alexander-schranz alexander-schranz enabled auto-merge (squash) June 24, 2023 11:54
@alexander-schranz alexander-schranz merged commit c934033 into sulu:2.6 Jun 24, 2023
7 checks passed
@alexander-schranz
Copy link
Member

@stollr Thank you!

@stollr
Copy link
Contributor Author

stollr commented Jun 24, 2023

You're welcome

@stollr stollr deleted the normalizer-supported-types branch June 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants