Remove sulu-link tags completely if they are invalid #7104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
added a commit
to mamazu/sulu-docs
that referenced
this pull request
Jun 25, 2023
mamazu
added a commit
to mamazu/sulu-docs
that referenced
this pull request
Jun 25, 2023
mamazu
force-pushed
the
link-remove-if-non-existant
branch
from
cb4c287
to
23798db
Compare
alexander-schranz
approved these changes
Jun 26, 2023
|
Looks good from my side. /cc @sulu/core-team do you agree with this new added feature and the name |
|
@mamazu @alexander-schranz this makes totally sense |
wachterjohannes
approved these changes
Jun 27, 2023
|
@mamazu Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
When specifying the 'remove-if-not-exist' property on a link to be true, then the entire tag (including it's contents will be removed)
Why?
To prevent links that are invalid and text that (when it's not a link) looks weird. Like if you have a link list and one of the links is broken, it would be better to remove the text as well.
Example Usage
To Do