-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frontend handling for 404 responses of form resources #7108
Merged
Prokyonn
merged 1 commit into
sulu:2.6
from
alexander-schranz:feature/show-not-found-error
Jun 29, 2023
Merged
Add frontend handling for 404 responses of form resources #7108
Prokyonn
merged 1 commit into
sulu:2.6
from
alexander-schranz:feature/show-not-found-error
Jun 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/show-not-found-error
branch
from
June 29, 2023 10:44
96433cf
to
83f7080
Compare
alexander-schranz
force-pushed
the
feature/show-not-found-error
branch
4 times, most recently
from
June 29, 2023 11:03
c31c531
to
1da9dc6
Compare
alexander-schranz
force-pushed
the
feature/show-not-found-error
branch
from
June 29, 2023 11:06
1da9dc6
to
d192cc2
Compare
alexander-schranz
force-pushed
the
feature/show-not-found-error
branch
2 times, most recently
from
June 29, 2023 11:12
f404aae
to
3234f4d
Compare
src/Sulu/Bundle/AdminBundle/Resources/js/stores/ResourceStore/ResourceStore.js
Show resolved
Hide resolved
alexander-schranz
force-pushed
the
feature/show-not-found-error
branch
from
June 29, 2023 11:17
3234f4d
to
7082c3c
Compare
Prokyonn
reviewed
Jun 29, 2023
src/Sulu/Bundle/AdminBundle/Resources/js/components/PermissionHint/PermissionHint.js
Show resolved
Hide resolved
src/Sulu/Bundle/AdminBundle/Resources/js/components/PermissionHint/PermissionHint.js
Show resolved
Hide resolved
src/Sulu/Bundle/AdminBundle/Resources/js/components/PermissionHint/README.md
Show resolved
Hide resolved
alexander-schranz
force-pushed
the
feature/show-not-found-error
branch
4 times, most recently
from
June 29, 2023 13:35
1d7cac8
to
8b388cd
Compare
Prokyonn
approved these changes
Jun 29, 2023
alexander-schranz
force-pushed
the
feature/show-not-found-error
branch
from
June 29, 2023 13:43
8b388cd
to
9f1d68d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add frontend handling for 404 responses of form resources.
Why?
Currently there was infinite loader shown when 404 was responded by a resource.