Improve the device detector runtime by wiring the system cache if present

[xabbuh]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Fixed tickets
Related issues/PRs
License	MIT
Documentation PR

What's in this PR?

Use Symfony's system cache pool when it is present to cache data read from YAML files by the device detector.

Why?

The DeviceDetector class scans several YAML files which never change during runtime. This consumes most of the CPU time when e.g. /_sulu_target_group is requested. Caching the parsed result improves this a lot.

[alexander-schranz]

Error: Class "DeviceDetector\Cache\PSR6Bridge" not found sounds like we need to increase the matomo device detector version form ^3.7.0 to ^3.9.0

[xabbuh]

Should I bump the dependency or add a check for the PSR6Bridge class?

[alexander-schranz]

Would just increase the version to ^3.9, current lowest is already ^3.7 so that is not lot of diff here for people to update.

[alexander-schranz]

The PHPStan issue seems to be related that constant_hasser: false is not working correctly here (https://github.com/phpstan/phpstan-symfony#constant-hassers):

sulu/phpstan.neon

Line 36 in 60155ff

constant_hassers: false

So you can currently add that errors to the phpstan baseline.

[alexander-schranz]

Found the issue with phpstan (#7180) and will update the baselines on the target branches so you can ignore them currently.

[xabbuh]

feel free to ping me when #7180 is merged up and I can rebase here

[alexander-schranz]

Merged and also merged back to 2.6

[xabbuh]

@alexander-schranz Thank you! 👍

[alexander-schranz]

@xabbuh Thank you for this improvement 👍