Add sorting for snippet area / default snippets by title instead of key #7204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Changed the sorting of the snippet areas. They are sorted by title instead of their key (which is not visible in the frontend).
Why?
Currently the snippet areas are sorted by their key. But this makes it harder to scan the list for the user because titles may have the wrong order.
Note
I am using PHP's
Collate
class for comparing the string. But this is only available if the intl extension is loaded. So I have added a fallback to simplestrcmp
function, because the intl extension is not a requirement by Sulu.But I am unsure how to handle this in the unit tests. Is it okay how it is done?