Add pagination to admin search #7228
Conversation
alexander-schranz
changed the title
alexander-schranz
added
the
Design required
|
@zanturik Thx for working on this and sorry for the late response. I did give this a quick try but it looks like this isn't working. Maybe related to the removed zend lucene part or fasl? But it even not triggers a request so maybe related more to the JS part.
The pagination component itself is maybe a little bit small on small screens. So maybe we should make that atleast the same width as the search field. |
You are right, my bad, one line was not pushed. Fixed, Please test again.
I agree. The problem it that it's a Pagination component displaying results/pagination this way, I'm just reusing it. The problem itself comes from "max-width" of .search-result class. I think it should be fixed in a separate task, since it's not the only place where search is used and design in other places may differ. |
alexander-schranz
removed
the
Design required
fixed, please review. |
Search controller contained the code, needed to be able to run tests of page/limit parameters with TestAdapter. Fixed, now controller containes only code, that needed to run for the real adapters (Lucene/elastic). MassiveBundle TestAdapter is ignoring limit and page parameters of search requests, so it's impossible to test them correctly. Tests adjusted (doesn't try to test limit and page anymore).
alexander-schranz
force-pushed
the
bugfix/add-pagination-to-admin-search
branch
from
978a53d
to
734686a
Compare
|
@zanturik Looks good for me, Thanks you for the contribution! Auto merged when the CI finished. |
What's in this PR?
Add pagination to admin search page
Why?
Because good search pages contains pagination.
Example Usage
Search * in admin search page. Play with pagination.
To Do