Add anchor-field to MediaLinkTypeOverlay #7231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great to see this merged! |
alexander-schranz
force-pushed
the
patch-1
branch
from
b564ebf
to
b3b8475
Compare
As discussed in #7082 at least for PDF-media an URL fragment can be very useful (to jump to a specific page with `#page=12`). This PR adds that field (as a copy from the internal link overlay).
Just a little test for the new anchor field.
to match linting rules
to match linting rules.
to match linting rules.
spackmat
commented
May 2, 2024
|
Thx, I will update the snapshot tests, mostly a little bit tricky if your system may run on none english system. |
|
@spackmat Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds an anchor field to the MediaLinkTypeOverlay (as a copy from the internal link overlay, that already has one).
Why?
As discussed in #7082 at least for PDF-media an URL fragment can be very useful (to jump to a specific page with
#page=12).Example Usage
Links to a media files (mainly PDF files) can now get an anchor like
page=12within the overlay form (just like links to pages) that is appended to the link's URL like...longdocument.pdf#page=12.I didn't find any documentation for the link overlays, so there is no documentation PR,
To Do
Nothing from my point of view. Update: Added a test to cover that field.