Add a logger in the ResettingController #7257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
requested changes
Feb 5, 2024
src/Sulu/Bundle/SecurityBundle/Controller/ResettingController.php
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/SecurityBundle/Controller/ResettingController.php
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/SecurityBundle/Controller/ResettingController.php
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/SecurityBundle/Controller/ResettingController.php
Outdated
Show resolved
Hide resolved
| @@ -228,7 +240,9 @@ public function sendEmailAction(Request $request) | |||
| $email = $this->getEmail($user); | |||
| $this->sendTokenEmail($user, $this->getSenderAddress($request), $email, $token); | |||
| } catch (\Exception $ex) { | |||
| // do nothing | |||
| if ($this->logger instanceof LoggerInterface) { | |||
There was a problem hiding this comment.
This check can be avoided when fallback on __construct to new NullLogger.
mamazu
commented
Mar 5, 2024
| @@ -62,6 +62,7 @@ | |||
| <argument>%sulu_security.reset_password.mail.token_send_limit%</argument> | |||
| <argument>%sulu_admin.email%</argument> | |||
| <argument>%kernel.secret%%</argument> | |||
There was a problem hiding this comment.
Btw that looks like a typo is it supposed to have two percent signs?
There was a problem hiding this comment.
Looks wrong to me. Think this should be only one %. Currently it may just added always a % to the secret.
There was a problem hiding this comment.
I've opened an issue for that. I wouldn't want to fix that here.
mamazu
force-pushed
the
logging_errors_with_reset_token
branch
from
a0820ad
to
e8d801d
Compare
alexander-schranz
requested changes
Mar 18, 2024
src/Sulu/Bundle/SecurityBundle/Controller/ResettingController.php
Outdated
Show resolved
Hide resolved
alexander-schranz
force-pushed
the
logging_errors_with_reset_token
branch
from
7c85965
to
dcdec55
Compare
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
logging_errors_with_reset_token
branch
from
bd5579e
to
f70e286
Compare
alexander-schranz
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adding the logger to the ResettingController
Why?
Swallowing the error and not showing any errors is not very helpful for debugging purposes adding a Logger to at least log the error will help.